Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix typos in readme #1149

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: fix typos in readme #1149

wants to merge 1 commit into from

Conversation

timmy471
Copy link

@timmy471 timmy471 commented Oct 22, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel Vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 9:32am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 9:32am

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

github-actions[bot]
github-actions bot reviewed Oct 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

greptile-apps[bot]
greptile-apps bot reviewed Oct 22, 2024
View reviewed changes
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request addresses minor typos in the README.md file, enhancing the clarity and professionalism of the Million.js documentation.

  • Corrected 'doesn't needs' to 'doesn't need' in the Reconciliation section
  • Added the word 'for' in the Acknowledgments section, improving sentence clarity
  • Changes are non-code related, focusing solely on documentation improvement
  • Demonstrates attention to detail in maintaining high-quality project documentation

1 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile

README.md Show resolved Hide resolved
@timmy471
Copy link
Author

@NisargIO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmy471 @CLAassistant